Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility in example to ignore cert errors and fix the verify_ssl assignment in code #353

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

bunnis
Copy link
Contributor

@bunnis bunnis commented Oct 4, 2024

This addresses #298, adding it explicitly to the example and making it easier for new users to toggle it.
Additionally, the TCPConnector assignment was broken, and this was fixed too.

@bunnis bunnis requested a review from iMicknl as a code owner October 4, 2024 20:26
sagemcom_api/client.py Outdated Show resolved Hide resolved
Copy link
Owner

@iMicknl iMicknl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run pre-commit on both your PRs? Both PRs are not passing CI/CD due to style issues.

@bunnis
Copy link
Contributor Author

bunnis commented Oct 14, 2024

Could you let me know how I do that?

@iMicknl
Copy link
Owner

iMicknl commented Oct 15, 2024

Could you let me know how I do that?

If you use the devcontainer, it should be there by default where you commit. Otherwise you can run pre-commit run --all-files. I fixed them for you :).

@iMicknl iMicknl merged commit 429855c into iMicknl:main Oct 15, 2024
4 checks passed
@bunnis
Copy link
Contributor Author

bunnis commented Oct 15, 2024

Great thank you, sorry for that, I don't really know much about these tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants